[PATCH] D58042: [LiveDebugValues] Emit parameter's entry value

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:885
     const VarLoc &DiffIt = VarLocIDs[ID];
-    const MachineInstr *DMI = &DiffIt.MI;
+    const MachineInstr *DebugInstr = &DiffIt.MI;
     MachineInstr *MI =
----------------
Can you land this as an NFC refactoring (no need for a separate phab review?)


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:966
+    if (MI.isDebugValue() && IsUnmodifiedFuncParam(MI) &&
+        IsRegOtherThanSPAndFP(MI.getOperand(0)) && IsNewParameter(MI) &&
+        !IsFragment(MI.getDebugExpression()))
----------------
We need a longer comment here that explains why each of these conditions are necessary and what is being checked for.


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:967
+        IsRegOtherThanSPAndFP(MI.getOperand(0)) && IsNewParameter(MI) &&
+        !IsFragment(MI.getDebugExpression()))
+      DebugEntryVals.push_back(&MI);
----------------
Why can't fragments be entry values?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D58042/new/

https://reviews.llvm.org/D58042