[PATCH] D62030: [LLD] [MinGW] Implement the -v and --version flags for the MinGW driver

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo marked an inline comment as done.
mstorsjo added inline comments.


================
Comment at: MinGW/Driver.cpp:144
+  if (Args.hasArg(OPT_v) || Args.hasArg(OPT_version))
+    message(getLLDVersion() + " (compatible with GNU linkers)");
+
----------------
ruiu wrote:
> Do we need "(compatible with GNU linkers)"? This is a hack for compatibility with configure scripts (https://www.sigbus.info/software-compatibility-and-our-own-user-agent-problem). I don't know much about how linkers are detected on Windows for MinGW, but if you don't need it, you can remove it from the version message.
One of the main selling points of MinGW is that it works with the same configure/autotools/libtool based builds as lots of unix libraries. So yes, unfortunately, the same compatibility hack is needed here as well. Do you want me to bring along a bit more of the comment to point this out, to indicate that this is intentional?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62030/new/

https://reviews.llvm.org/D62030