[PATCH] D62030: [LLD] [MinGW] Implement the -v and --version flags for the MinGW driver

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 16 18:41:34 PDT 2019


ruiu added inline comments.


================
Comment at: MinGW/Driver.cpp:144
+  if (Args.hasArg(OPT_v) || Args.hasArg(OPT_version))
+    message(getLLDVersion() + " (compatible with GNU linkers)");
+
----------------
Do we need "(compatible with GNU linkers)"? This is a hack for compatibility with configure scripts (https://www.sigbus.info/software-compatibility-and-our-own-user-agent-problem). I don't know much about how linkers are detected on Windows for MinGW, but if you don't need it, you can remove it from the version message.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62030/new/

https://reviews.llvm.org/D62030





More information about the llvm-commits mailing list