[PATCH] D61767: [llvm-elfabi] Emit ELF header and string table section

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich marked an inline comment as done.
jakehehrlich added inline comments.


================
Comment at: llvm/test/tools/llvm-elfabi/write-elf64be-ehdr.test:1
+# RUN: llvm-elfabi %s --output-target=elf64-big %t
+# RUN: llvm-readobj --file-headers %t | FileCheck %s
----------------
MaskRay wrote:
> I should copy my comment to your earlier revision here. If at this early stage you don't care about big-endian, delete it, or at least make it realistic, e.g. `EM_PPC64`.
I think we want to care about the fact that we're not doing anything ELFT specific. The architectures currently added only include X86_64 and AArch64 so without adding support for that first I can't add that. It's a really simple change it just seems orthogonal and I don't see the benefit. If you want I'll add power pc as a supported arch in this change as well ahd change the test accordingly.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61767/new/

https://reviews.llvm.org/D61767