[PATCH] D61391: [AArc64] Handle ISD::LROUND and ISD::LLROUND

[Adhemerval Zanella via Phabricator via llvm-commits]

zatrazz marked an inline comment as done.
zatrazz added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:3076
 
+def : Pat<(i64 (lround f32:$Rn)),
+          (!cast<Instruction>(FCVTASUXSr) f32:$Rn)>;
----------------
SjoerdMeijer wrote:
> zatrazz wrote:
> > SjoerdMeijer wrote:
> > > I think this is supported too for f16s with Armv8.2.
> > Indeed it does, but FPToIntegerPats does not define a pattern for f16 currently. I think one possible addition would to extends fp to/from int pattern to f16 as well, however, I also think it is out the scope of this specific patch.
> Okay, I see, there's indeed a pattern missing for f16s in FPToIntegerPats, so that's indeed extra work that belongs to a follow up patch. Would be highly appreciated if you can follow this up with a patch, so that we don't run into this later.
Ok, I will add it on my backlog. I plan to send a lrint patch similar to lround, and then I will take a look at f16 support on FPToIntegerPats.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61391/new/

https://reviews.llvm.org/D61391