[PATCH] D61391: [AArc64] Handle ISD::LROUND and ISD::LLROUND

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Looks reasonable to me.



================
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:3076
 
+def : Pat<(i64 (lround f32:$Rn)),
+          (!cast<Instruction>(FCVTASUXSr) f32:$Rn)>;
----------------
zatrazz wrote:
> SjoerdMeijer wrote:
> > I think this is supported too for f16s with Armv8.2.
> Indeed it does, but FPToIntegerPats does not define a pattern for f16 currently. I think one possible addition would to extends fp to/from int pattern to f16 as well, however, I also think it is out the scope of this specific patch.
Okay, I see, there's indeed a pattern missing for f16s in FPToIntegerPats, so that's indeed extra work that belongs to a follow up patch. Would be highly appreciated if you can follow this up with a patch, so that we don't run into this later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61391/new/

https://reviews.llvm.org/D61391