[PATCH] D61980: GlobalISel: Add DstOp version of buildIntrinsic

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In D61980#1504116 <https://reviews.llvm.org/D61980#1504116>, @aditya_nandakumar wrote:

> In D61980#1504092 <https://reviews.llvm.org/D61980#1504092>, @arsenm wrote:
>
> > In D61980#1504074 <https://reviews.llvm.org/D61980#1504074>, @aditya_nandakumar wrote:
> >
> > > The patch looks good. One comment - does it make sense to have two functions or unify the implementation - make the non DstOp version forward to DstOp version?
> >
> >
> > It would require creating another vector constructing DstOps, which seems worse
>
>
> Fair enough. I'm not strongly opinionated here - either way is good for me.


There is some inconsistency in the current set of APIs. buildUnmerge provides ArrayRef<LLT> and ArrayRef<unsigned> variants, whereas buildInstr uses ArrayRef<DstOp>


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61980/new/

https://reviews.llvm.org/D61980