[PATCH] D61980: GlobalISel: Add DstOp version of buildIntrinsic

Aditya Nandakumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 15 20:45:42 PDT 2019


aditya_nandakumar accepted this revision.
aditya_nandakumar added a comment.
This revision is now accepted and ready to land.

In D61980#1504092 <https://reviews.llvm.org/D61980#1504092>, @arsenm wrote:

> In D61980#1504074 <https://reviews.llvm.org/D61980#1504074>, @aditya_nandakumar wrote:
>
> > The patch looks good. One comment - does it make sense to have two functions or unify the implementation - make the non DstOp version forward to DstOp version?
>
>
> It would require creating another vector constructing DstOps, which seems worse


Fair enough. I'm not strongly opinionated here - either way is good for me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61980/new/

https://reviews.llvm.org/D61980





More information about the llvm-commits mailing list