[PATCH] D61941: [llvm-objdump]Improve testing of some switches #1

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/tools/llvm-objdump/section-filter.test:66
+
+## Show non-executable sections are not disassembled even if specified,
+## and that only the specified executable sections are disassembled.
----------------
objdump -d -j.data  dumps non-executable sections.


================
Comment at: test/tools/llvm-objdump/section-filter.test:74
+
+## Show that only the specified relocation sections that patch the
+## disassembled sections are dumped.
----------------
This is no GNU behavior, either... `objdump -d -r -j.text` dumps `.rela.text`.

Thanks for the tests. We can improve these aspects...


================
Comment at: test/tools/llvm-objdump/section-filter.test:213
+
+## Test that an unknown section name causes all section output to be suppressed.
+# RUN: llvm-objdump %t.h.elf -h --section foobar \
----------------
Apparently we missed a GNU objdump warning...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61941/new/

https://reviews.llvm.org/D61941