[PATCH] D61154: [PredicateInfo] Do not process unreachable operands.

[Taewook Oh via Phabricator via llvm-commits]

twoh updated this revision to Diff 199648.
twoh added a comment.

Thank you for your comments @efriedma! I addressed your comments and added a test case. The test segfaults clang without proposed change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61154/new/

https://reviews.llvm.org/D61154

Files:
  llvm/lib/Transforms/Utils/PredicateInfo.cpp
  llvm/test/Transforms/Util/PredicateInfo/unreachable.ll


Index: llvm/test/Transforms/Util/PredicateInfo/unreachable.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/Util/PredicateInfo/unreachable.ll
@@ -0,0 +1,25 @@
+; RUN: opt -print-predicateinfo < %s 2>&1 | FileCheck %s
+
+declare void @foo()
+declare void @llvm.assume(i1)
+
+define void @bar(i32* %p) {
+entry:
+; CHECK-LABEL: @bar
+  br label %end
+
+unreachable1:
+  %v1 = load i32, i32* %p, align 4
+  %c1 = icmp eq i32 %v1, 0
+  call void @llvm.assume(i1 %c1)
+  br label %unreachable2
+
+unreachable2:
+  %v2 = load i32, i32* %p, align 4
+  %c2 = icmp eq i32 %v2, 0
+  call void @llvm.assume(i1 %c2)
+  br label %end
+
+end:
+  ret void
+}
Index: llvm/lib/Transforms/Utils/PredicateInfo.cpp
===================================================================
--- llvm/lib/Transforms/Utils/PredicateInfo.cpp
+++ llvm/lib/Transforms/Utils/PredicateInfo.cpp
@@ -473,7 +473,8 @@
   }
   for (auto &Assume : AC.assumptions()) {
     if (auto *II = dyn_cast_or_null<IntrinsicInst>(Assume))
-      processAssume(II, II->getParent(), OpsToRename);
+      if (DT.getNode(II->getParent()))
+        processAssume(II, II->getParent(), OpsToRename);
   }
   // Now rename all our operations.
   renameUses(OpsToRename);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61154.199648.patch
Type: text/x-patch
Size: 1273 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190515/422de077/attachment.bin>