[PATCH] D61154: [PredicateInfo] Do not process unreachable operands.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 14 12:13:27 PDT 2019
efriedma added a comment.
Testcase?
For any non-PHI instruction that is reachable, all of its operands must also be reachable. We can use this to reduce the number of places we need to check for reachability. I'm pretty sure the new checks in processSwitch and processBranch are useless: iterating over the domtree will not visit unreachable blocks. And we should probably add a check to PredicateInfo::buildPredicateInfo to avoid processing assumes in unreachable code, rather than checking the reachability of the operands of an assume.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61154/new/
https://reviews.llvm.org/D61154
More information about the llvm-commits
mailing list