[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

[Alfredo Dal'Ava Júnior via Phabricator via llvm-commits]

adalava marked an inline comment as done.
adalava added inline comments.


================
Comment at: clang/lib/Basic/Targets/PPC.h:382
       resetDataLayout("e-m:e-i64:64-n32:64");
-      ABI = "elfv2";
     } else {
----------------
MaskRay wrote:
> MaskRay wrote:
> > Have you researched how GNU as chooses the default ABI?
> > 
> > I think the change may break some Linux ppc64le users as they expect the default elfv2.
> Sorry, it won't :) Then I think it is fine.
I didn't look the code, but behavior on GNU is the same as LLVM too:
-  powerpc64-* and elfv2 if "powerpc64le-*" and last

I found setting the ABI value here is useless so I decided to remove to keep it consistent with it's  "sister" X86 class and checked that no tests are broken after this, but would be nice if someone with more LLVm experience could give another look.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61950/new/

https://reviews.llvm.org/D61950