[PATCH] D61950: [PowerPC64] adds ABI parsing when specified on target triple

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCTargetMachine.cpp:217
   case Triple::ppc64:
-    return PPCTargetMachine::PPC_ABI_ELFv1;
+    // if ELFv2 on target triple i.e. powerpc64-unknown-freebsd12.0-elfv2
+    if (TT.getEnvironment() == llvm::Triple::ELFv2)
----------------
The initial word should be capitalized and the sentence should end with a period. At least this part of the comment (`if ELFv2 on target triple `) is redundant. I don't know if the other half `powerpc64-unknown-freebsd12.0-elfv2` is useful...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61950/new/

https://reviews.llvm.org/D61950