[PATCH] D61890: [LiveDebugValues] End variable's range with multiple locations at block entry

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 15 02:03:29 PDT 2019


dstenb added inline comments.


================
Comment at: test/DebugInfo/MIR/X86/dbg-live-debug-values-end-range.mir:20-21
+#}
+# CHECK: DBG_VALUE 123, $noreg, ![[LOCALVAR:.*]]
+# CHECK: DBG_VALUE $noreg, $noreg, ![[LOCALVAR]]
+--- |
----------------
It could be good to add CHECK(-LABEL)s for the basic block labels before each DBG_VALUE, e.g.:


```
CHECK-LABEL: bb.2.if.end:
CHECK: DBG_VALUE $noreg, $noreg, ![[LOCALVAR]] 
```

(and perhaps also add a check for `bb.1`'s DBG_VALUE?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61890/new/

https://reviews.llvm.org/D61890





More information about the llvm-commits mailing list