[PATCH] D61890: [LiveDebugValues] End variable's range with multiple locations at block entry

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added inline comments.


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:789
     // predecessor, and for all other predecessors join the Out locs.
-    if (!NumVisited)
+    // Also keep track about variables that have multiple locations
+    // so that we can close theirs range since we can't decide which location
----------------
aprantl wrote:
> multiple locations .. inside this BB?
Grammar nit: about->of


================
Comment at: lib/CodeGen/LiveDebugValues.cpp:790
+    // Also keep track about variables that have multiple locations
+    // so that we can close theirs range since we can't decide which location
+    // we should take.
----------------
Grammar nit: theirs->their


================
Comment at: test/DebugInfo/MIR/X86/dbg-stack-value-range.mir:1
+# RUN: llc -start-before=livedebugvalues %s -filetype=obj -o -| llvm-dwarfdump -debug-info -| FileCheck %s
+#
----------------
Is this test case really necessary? It seems you are mainly testing that the DWARF ranges are generated correctly, which they should be, since there was no change to DbgEntityHistoryCalculator.

If you feel that it is necessary, perhaps it would be better to use assembly output so we don't check for exact code ranges?  It may be easier to verify that the location list range does not extend all the way to the end of the function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61890/new/

https://reviews.llvm.org/D61890