[PATCH] D61846: [DAGCombiner] Fix invalid alias analysis.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Wed May 15 01:30:43 PDT 2019


Thanks!

On Wed, May 15, 2019, 1:19 AM Clement Courbet via Phabricator <
reviews at reviews.llvm.org> wrote:

> courbet marked 2 inline comments as done.
> courbet added inline comments.
>
>
> ================
> Comment at: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:19802
>    bool IsAlias;
>    if (BaseIndexOffset::computeAliasing(Op0, MUC0.NumBytes, Op1,
> MUC1.NumBytes,
> +                                       DAG, IsAlias))
> ----------------
> echristo wrote:
> > Can you comment this? Given it's already caused a problem and isn't
> obvious what's going on necessarily.
> Sure.
>
>
>
>
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D61846/new/
>
> https://reviews.llvm.org/D61846
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190515/17f43005/attachment.html>


More information about the llvm-commits mailing list