<div dir="auto"><div>Thanks!<br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, May 15, 2019, 1:19 AM Clement Courbet via Phabricator <<a href="mailto:reviews@reviews.llvm.org">reviews@reviews.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">courbet marked 2 inline comments as done.<br>
courbet added inline comments.<br>
<br>
<br>
================<br>
Comment at: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:19802<br>
   bool IsAlias;<br>
   if (BaseIndexOffset::computeAliasing(Op0, MUC0.NumBytes, Op1, MUC1.NumBytes,<br>
+                                       DAG, IsAlias))<br>
----------------<br>
echristo wrote:<br>
> Can you comment this? Given it's already caused a problem and isn't obvious what's going on necessarily.<br>
Sure. <br>
<br><br><br><br>
<br>
Repository:<br>
  rL LLVM<br>
<br>
CHANGES SINCE LAST ACTION<br>
  <a href="https://reviews.llvm.org/D61846/new/" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D61846/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D61846" rel="noreferrer noreferrer" target="_blank">https://reviews.llvm.org/D61846</a><br>
<br>
<br>
<br>
</blockquote></div></div></div>