[PATCH] D61712: [ELF] Initialize Target before it may be referenced by findAux when reporting "duplicate symbol" error
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 13 06:42:04 PDT 2019
grimar added inline comments.
================
Comment at: lld/trunk/test/ELF/undef-broken-debug.test:11
+# We used to dereference null Target in DWARF.cpp:findAux while reporting a duplicate symbol error,
+# because Target wasn't initialized yet.
----------------
nit: I would not refer to the `DWARF.cpp:findAux` in the test cases comment.
Simply because both the file name and function name might change.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61712/new/
https://reviews.llvm.org/D61712
More information about the llvm-commits
mailing list