[PATCH] D55897: Add constrained fptrunc and fpext intrinsics

Fri May 10 13:05:18 PDT 2019

cameron.mcinally added inline comments.

================
Comment at: include/llvm/IR/Intrinsics.td:691
 }
-// FIXME: Add intrinsics for fcmp, fptrunc, fpext, fptoui and fptosi.
-// FIXME: Add intrinsics for fabs and copysign?
----------------
craig.topper wrote:
> A lot of this FIXME still applies doesn't it?
We definitely need FCMP. I attempted a patch for this, D54649, but FCMP is Custom lowered on X86. We still need a good way to handle STRICT nodes that need to be Custom lowered.

Also FYI that the line below can be removed. We decided not to implement constrained FABS and FCOPYSIGN... unless a problem is found.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55897/new/

https://reviews.llvm.org/D55897