[PATCH] D55897: Add constrained fptrunc and fpext intrinsics

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: include/llvm/IR/Intrinsics.td:691
 }
-// FIXME: Add intrinsics for fcmp, fptrunc, fpext, fptoui and fptosi.
-// FIXME: Add intrinsics for fabs and copysign?
----------------
A lot of this FIXME still applies doesn't it?


================
Comment at: lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:3215
+  EVT InWidenVT = EVT::getVectorVT(*DAG.getContext(), InEltVT, WidenNumElts);
+  SmallVector<EVT, 2> InWidenVTs = { InWidenVT, MVT::Other };
+
----------------
I think this is an unused variable


================
Comment at: lib/IR/Verifier.cpp:4708
+    Assert(OperandTy->isFPOrFPVectorTy(),
+             "Intrinsic first argument must be FP or FP vector", &FPI);
+    Assert(ResultTy->isFPOrFPVectorTy(),
----------------
Indented too far


================
Comment at: lib/IR/Verifier.cpp:4710
+    Assert(ResultTy->isFPOrFPVectorTy(),
+             "Intrinsic result must be FP or FP vector", &FPI);
+    Assert(OperandTy->isVectorTy() == ResultTy->isVectorTy(),
----------------
Indented too far


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55897/new/

https://reviews.llvm.org/D55897