[PATCH] D60243: [LSan][AArch64] Speed-up leak and address sanitizers on AArch64 for 47-bit VMA

Brian Rzycki via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 10 08:10:23 PDT 2019


brzycki added inline comments.


================
Comment at: compiler-rt/lib/lsan/lsan_allocator.cc:38
 static Allocator allocator;
+bool UseAllocator32 = false;
 
----------------
brzycki wrote:
> Needs to be under `#if defined(__aarch64__)` or `UseAllocator32` needs to be moved outside of the Aarch64 define in `lsan_allocator.h`.
Nevermind, I now see what you're doing. It's fine as it is.


================
Comment at: compiler-rt/lib/lsan/lsan_allocator.cc:46
+  else
+    UseAllocator32 = false;
+
----------------
brzycki wrote:
> Needs to be under `#if defined(__aarch64__)` or `UseAllocator32` needs to be moved outside of the Aarch64 define in `lsan_allocator.h`.
Nevermind, I now see what you're doing. It's fine as it is.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60243/new/

https://reviews.llvm.org/D60243





More information about the llvm-commits mailing list