[PATCH] D60243: [LSan][AArch64] Speed-up leak and address sanitizers on AArch64 for 47-bit VMA

[Brian Rzycki via Phabricator via llvm-commits]

brzycki added a comment.

@sebpop welcome back! I'm glad you received clearance to work on this.  :)  My comments are inline.



================
Comment at: compiler-rt/lib/lsan/lsan_allocator.cc:38
 static Allocator allocator;
+bool UseAllocator32 = false;
 
----------------
Needs to be under `#if defined(__aarch64__)` or `UseAllocator32` needs to be moved outside of the Aarch64 define in `lsan_allocator.h`.


================
Comment at: compiler-rt/lib/lsan/lsan_allocator.cc:46
+  else
+    UseAllocator32 = false;
+
----------------
Needs to be under `#if defined(__aarch64__)` or `UseAllocator32` needs to be moved outside of the Aarch64 define in `lsan_allocator.h`.


================
Comment at: compiler-rt/lib/lsan/lsan_allocator.h:137
+  using AddressSpaceView = Allocator32::AddressSpaceView;
+  using AllocatorCache = DoubleAllocatorCache;
+
----------------
Is this correct? This is part of what I was commenting on in my previous patch. We're always using the 32-bit versions of `MapUnmapCallback` and `AddressSpaceView` even if we switch at run-time to the 64-bit allocator. @vitalybuka would know better than I if this is guaranteed to be the same across 32/64 on the same arch or not.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60243/new/

https://reviews.llvm.org/D60243