[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 9 20:46:10 PDT 2019


mehdi_amini marked an inline comment as done.
mehdi_amini added inline comments.


================
Comment at: tools/polly/CMakeLists.txt:212
+register_llvm_extension(polly)
+set_property(TARGET bugpoint APPEND PROPERTY EXTENSIONS LLVMTarget)
----------------
Meinersbur wrote:
> mehdi_amini wrote:
> > That looks like leftover experiments?
> This was likely added as one of my comments: Polly-ACC requires the NVPTX target to be present in the executable it is linked to. bugpoint by default does not depend on LLVMTarget, i.e. does not contain the NVPTX target.
Yes, I saw the code removed in CMakeLists.txt after writing this comment but forgot to delete it before sending, sorry.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61446/new/

https://reviews.llvm.org/D61446





More information about the llvm-commits mailing list