[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Thu May 9 20:33:29 PDT 2019

Meinersbur added a comment.

In D61446#1493738 <https://reviews.llvm.org/D61446#1493738>, @serge-sans-paille wrote:

> @Meinersbur, I've tested and reviewed this patch, I'm curious about Polly's team opinion on the changes in current state?

I will have to try out the patch, e.g. on Windows. Please ping me if it takes to long.

================
Comment at: cmake/modules/AddLLVM.cmake:808
+    message(STATUS "Registering ${name} as a compiler extension")
+    set(LLVM_ALL_EXTENSION_TARGETS clang;bugpoint;opt)
+    foreach(tool ${LLVM_ALL_EXTENSION_TARGETS})
----------------
According to a recent [[ https://groups.google.com/forum/#!topic/polly-dev/BeC_v_oJIVM | mailing list posting ]], lld might need to have such tools linked-in as well for LTO.

================
Comment at: tools/polly/CMakeLists.txt:212
+register_llvm_extension(polly)
+set_property(TARGET bugpoint APPEND PROPERTY EXTENSIONS LLVMTarget)
----------------
mehdi_amini wrote:
> That looks like leftover experiments?
This was likely added as one of my comments: Polly-ACC requires the NVPTX target to be present in the executable it is linked to. bugpoint by default does not depend on LLVMTarget, i.e. does not contain the NVPTX target.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61446/new/

https://reviews.llvm.org/D61446