[PATCH] D61267: Update Phabricator.rst

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 9 15:17:18 PDT 2019


jyknight added inline comments.


================
Comment at: llvm/docs/Phabricator.rst:71
+and ``Subscribers`` in your commit message. ``arc`` requires one or more
+Reviewers (finding-reviewer-names_) and Subscribers should be the appropriate
+**-commits** list(s) from `listinfo <https://lists.llvm.org/mailman/listinfo>`_.
----------------
hintonda wrote:
> I think it would be helpful to include the subscribers info @benhamilton provided.
I'd add one more sentence here, to tell people that in the case that they are doing the currently-recommend thing, they do _NOT_ need to worry about this. Something like:
 "If you are working off a clone of the official https://github.com/llvm/llvm-project/ repository, Phabricator will subscribe the correct lists automatically. Otherwise, please add the relevant ones yourself."

LGTM otherwise!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61267/new/

https://reviews.llvm.org/D61267





More information about the llvm-commits mailing list