[PATCH] D61711: [ELF][Driver] Fix precedence of symbol ordering file and CGProfile

Wed May 8 18:28:23 PDT 2019

ruiu added a comment.

> (1) When both --symbol-ordering-file=<file> and --call-graph-order-file=<file> are present, whichever flag comes later will take precedence.

It looks like this combination is a misuse of the feature. Instead of silently ignore a flag, I think we should report an error that these flags cannot be used together.

> (2) When only --symbol-ordering-file=<file> is present, it takes precedence over implicit call graph (CGProfile) generated by CGProfilePass enabled in new pass manager.

This is fine by me.

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61711/new/

https://reviews.llvm.org/D61711