[PATCH] D61711: [ELF][Driver] Fix precedence of symbol ordering file and CGProfile

[Tiancong Wang via Phabricator via llvm-commits]

tcwang created this revision.
tcwang added reviewers: ruiu, george.burgess.iv, pcc.
tcwang added a project: lld.
Herald added subscribers: llvm-commits, MaskRay, arichardson, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

This patch is a fix for https://bugs.llvm.org/show_bug.cgi?id=41804.

      

We try to solve the precedence of user-specified symbol ordering file and C3 ordering provided as call graph. It deals with two case:

      

(1) When both --symbol-ordering-file=<file> and --call-graph-order-file=<file> are present, whichever flag comes later will take precedence.

     

(2) When only --symbol-ordering-file=<file> is present, it takes precedence over implicit call graph (CGProfile) generated by CGProfilePass enabled in new pass manager.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D61711

Files:
  lld/ELF/Driver.cpp
  lld/test/ELF/symbol-ordering-file-cgprofile-obj.s
  lld/test/ELF/symbol-ordering-file-cgprofile-txt.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61711.198752.patch
Type: text/x-patch
Size: 5068 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190509/ef46220e/attachment.bin>