[PATCH] D61674: [llvm-objcopy] Improve error message for unrecognised archive member

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/archive-unknown-members.test:31
+## Verify that the first member was not modified, if a later member could not
+## be recognised.
+# RUN: cmp %t.o %t1.o
----------------
jhenderson wrote:
> grimar wrote:
> > MaskRay wrote:
> > > grimar wrote:
> > > > recognised->recognized :]
> > > recognised is not wrong..
> > As far I understand there is a difference between British and American English.
> > Since our error messages spelling "recognized", i.e. in American way, I think it is good for
> > comments to be consistent. See rL360252
> I thought I read somewhere that the standard was American English in LLVM, but I now can't find it, so maybe I imagined it?
Honestly saying I suggested to change unrecognised -> unrecognized initially because my spellchecker complained about this word. I realized that it is a British style only after your first reply :) I do not know what is the LLVM standard (I would not expect to see such a requirement probably.)

Having consistency in spelling is not that bad still I think. I.e. in this test error messages spelling wasn't consistent with the comments before and now it is. But perhaps it is really was too subtle to care about?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61674/new/

https://reviews.llvm.org/D61674