[PATCH] D61674: [llvm-objcopy] Improve error message for unrecognised archive member

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 8 06:46:55 PDT 2019


jhenderson marked an inline comment as done.
jhenderson added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/archive-unknown-members.test:31
+## Verify that the first member was not modified, if a later member could not
+## be recognised.
+# RUN: cmp %t.o %t1.o
----------------
grimar wrote:
> MaskRay wrote:
> > grimar wrote:
> > > recognised->recognized :]
> > recognised is not wrong..
> As far I understand there is a difference between British and American English.
> Since our error messages spelling "recognized", i.e. in American way, I think it is good for
> comments to be consistent. See rL360252
I thought I read somewhere that the standard was American English in LLVM, but I now can't find it, so maybe I imagined it?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61674/new/

https://reviews.llvm.org/D61674





More information about the llvm-commits mailing list