[PATCH] D61435: [AArch64] NFC: Add generic StackOffset to describe scalable offsets.

[Diana Picus via Phabricator via llvm-commits]

rovka accepted this revision.
rovka added a comment.
This revision is now accepted and ready to land.

LGTM with nits. Thanks!



================
Comment at: unittests/Target/AArch64/TestStackOffset.cpp:27
+  StackOffset A(1, MVT::i64);
+  StackOffset B(1, MVT::i32);
+  StackOffset C = A + B;
----------------
Nitpick: Should also test offsets different than 1.


================
Comment at: unittests/Target/AArch64/TestStackOffset.cpp:51
+  EXPECT_TRUE(A.isZero());
+  EXPECT_TRUE((A+B).isZero());
+}
----------------
Nitpick: A negative test would also be nice.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61435/new/

https://reviews.llvm.org/D61435