[PATCH] D60037: [PowerPC] Use the two-constant NR algorithm for refining estimates

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai marked an inline comment as done.
nemanjai added inline comments.


================
Comment at: lib/Target/PowerPC/PPC.td:140
+  SubtargetFeature<"two-const-nr", "NeedsTwoConstNR", "true",
+                   "Requires two constant Newton-Rhapson computation">;
 def FeatureP8Altivec : SubtargetFeature<"power8-altivec", "HasP8Altivec", "true",
----------------
stefanp wrote:
> nit:
> I think it is "Newton-Raphson" not "Newton-Rhapson".
Thanks. I'll fix it.


================
Comment at: lib/Target/PowerPC/PPCSubtarget.h:101
   bool HasVSX;
+  bool NeedsTwoConstNR;
   bool HasP8Vector;
----------------
stefanp wrote:
> I think that this variable needs to be initialized to `false` in `void PPCSubtarget::initializeEnvironment()`.
Ah, good catch. I forgot about that.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60037/new/

https://reviews.llvm.org/D60037