[compiler-rt] r359835 - Fix check-builtins on Windows after alias changes

[Reid Kleckner via llvm-commits]

> On Thu, 2 May 2019, Reid Kleckner via llvm-commits wrote:
>
> > Author: rnk
> > Date: Thu May  2 15:11:55 2019
> > New Revision: 359835
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=359835&view=rev
> > Log:
> > Fix check-builtins on Windows after alias changes
> >
> > Modified:
> >    compiler-rt/trunk/lib/builtins/comparedf2.c
> >    compiler-rt/trunk/lib/builtins/comparesf2.c
> >    compiler-rt/trunk/test/builtins/Unit/compiler_rt_logb_test.c
> >
> > Modified: compiler-rt/trunk/lib/builtins/comparedf2.c
> > URL:
> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/builtins/comparedf2.c?rev=359835&r1=359834&r2=359835&view=diff
> >
> ==============================================================================
> > --- compiler-rt/trunk/lib/builtins/comparedf2.c (original)
> > +++ compiler-rt/trunk/lib/builtins/comparedf2.c Thu May  2 15:11:55 2019
> > @@ -140,3 +140,11 @@ AEABI_RTABI int __aeabi_dcmpun(fp_t a, f
> > COMPILER_RT_ALIAS(__unorddf2, __aeabi_dcmpun)
> > #endif
> > #endif
> > +
> > +#if defined(_WIN32)
> > +// The alias mechanism doesn't work on Windows, so emit wrapper
> functions.
>
> On MinGW, the same __attribute__((__alias__())) is used as for ELF, so
> this caused duplicate definitions of these symbols. I went ahead and
> pushed a fix for it.
>

Thanks! Sorry about that, I was under the impression that we didn't emit
the libgcc aliases at all on Windows, but it makes sense to emit them in a
mingw environment, since we would want to provide symbols that GCC-compiled
code expects to exist.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190503/44906ca2/attachment.html>