[compiler-rt] r359835 - Fix check-builtins on Windows after alias changes

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Fri May 3 00:42:17 PDT 2019


On Thu, 2 May 2019, Reid Kleckner via llvm-commits wrote:

> Author: rnk
> Date: Thu May  2 15:11:55 2019
> New Revision: 359835
>
> URL: http://llvm.org/viewvc/llvm-project?rev=359835&view=rev
> Log:
> Fix check-builtins on Windows after alias changes
>
> Modified:
>    compiler-rt/trunk/lib/builtins/comparedf2.c
>    compiler-rt/trunk/lib/builtins/comparesf2.c
>    compiler-rt/trunk/test/builtins/Unit/compiler_rt_logb_test.c
>
> Modified: compiler-rt/trunk/lib/builtins/comparedf2.c
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/builtins/comparedf2.c?rev=359835&r1=359834&r2=359835&view=diff
> ==============================================================================
> --- compiler-rt/trunk/lib/builtins/comparedf2.c (original)
> +++ compiler-rt/trunk/lib/builtins/comparedf2.c Thu May  2 15:11:55 2019
> @@ -140,3 +140,11 @@ AEABI_RTABI int __aeabi_dcmpun(fp_t a, f
> COMPILER_RT_ALIAS(__unorddf2, __aeabi_dcmpun)
> #endif
> #endif
> +
> +#if defined(_WIN32)
> +// The alias mechanism doesn't work on Windows, so emit wrapper functions.

On MinGW, the same __attribute__((__alias__())) is used as for ELF, so 
this caused duplicate definitions of these symbols. I went ahead and 
pushed a fix for it.

// Martin



More information about the llvm-commits mailing list