[PATCH] D61411: [SelectionDAG] Expand ADD/SUBCARRY

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 16:22:53 PDT 2019


efriedma accepted this revision.
efriedma added a comment.

LGTM with a minor comment.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3312
+    Results.push_back(
+        DAG.getBoolExtOrTrunc(ResultCarry, dl, CarryType, CarryType));
+    break;
----------------
Shouldn't matter in practice, but the second type passed to getBoolExtOrTrunc is supposed to be the type of the operation ("VT").


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61411/new/

https://reviews.llvm.org/D61411





More information about the llvm-commits mailing list