[PATCH] D61411: [SelectionDAG] Expand ADD/SUBCARRY

[Leonard Chan via Phabricator via llvm-commits]

leonardchan added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3293
+    SDValue CarryExt =
+        DAG.getZeroExtendInReg(DAG.getZExtOrTrunc(Carry, dl, VT), dl, VT);
+    SDValue Sum2 = DAG.getNode(Op, dl, VT, Sum, CarryExt);
----------------
efriedma wrote:
> The VT argument for getZeroExtendInReg is the mask, so should be MVT::i1.  The way it's written, the getZeroExtendInReg does nothing.
Updated


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61411/new/

https://reviews.llvm.org/D61411