[llvm] r359380 - [llvm-nm] Support section type 'u': STB_GNU_UNIQUE

Jordan Rupprecht via llvm-commits llvm-commits at lists.llvm.org
Thu May 2 15:10:16 PDT 2019


Looks like r359383 accidentally reverted this anyway.

In the future, please include tests with your commits.

On Thu, May 2, 2019 at 2:23 PM Jordan Rupprecht <rupprecht at google.com>
wrote:

> Please add a test
>
> On Sat, Apr 27, 2019 at 8:30 AM Fangrui Song via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Author: maskray
>> Date: Sat Apr 27 08:32:53 2019
>> New Revision: 359380
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=359380&view=rev
>> Log:
>> [llvm-nm] Support section type 'u': STB_GNU_UNIQUE
>>
>> Modified:
>>     llvm/trunk/tools/llvm-nm/llvm-nm.cpp
>>
>> Modified: llvm/trunk/tools/llvm-nm/llvm-nm.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-nm/llvm-nm.cpp?rev=359380&r1=359379&r2=359380&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/tools/llvm-nm/llvm-nm.cpp (original)
>> +++ llvm/trunk/tools/llvm-nm/llvm-nm.cpp Sat Apr 27 08:32:53 2019
>> @@ -934,6 +934,10 @@ static char getSymbolNMTypeChar(ELFObjec
>>      return '?';
>>    }
>>
>> +  uint8_t Binding = SymI->getOther() >> 4;
>> +  if (Binding == ELF::STB_GNU_UNIQUE)
>> +    return 'u';
>> +
>>    elf_section_iterator SecI = *SecIOrErr;
>>    if (SecI != Obj.section_end()) {
>>      uint32_t Type = SecI->getType();
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190502/51e85d76/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4849 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190502/51e85d76/attachment.bin>


More information about the llvm-commits mailing list