<div dir="ltr"><div dir="ltr">Looks like r359383 accidentally reverted this anyway.</div><div dir="ltr"><br></div><div>In the future, please include tests with your commits.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, May 2, 2019 at 2:23 PM Jordan Rupprecht <<a href="mailto:rupprecht@google.com">rupprecht@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr">Please add a test</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sat, Apr 27, 2019 at 8:30 AM Fangrui Song via llvm-commits <<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Author: maskray<br>
Date: Sat Apr 27 08:32:53 2019<br>
New Revision: 359380<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=359380&view=rev" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project?rev=359380&view=rev</a><br>
Log:<br>
[llvm-nm] Support section type 'u': STB_GNU_UNIQUE<br>
<br>
Modified:<br>
    llvm/trunk/tools/llvm-nm/llvm-nm.cpp<br>
<br>
Modified: llvm/trunk/tools/llvm-nm/llvm-nm.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-nm/llvm-nm.cpp?rev=359380&r1=359379&r2=359380&view=diff" rel="noreferrer" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-nm/llvm-nm.cpp?rev=359380&r1=359379&r2=359380&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/tools/llvm-nm/llvm-nm.cpp (original)<br>
+++ llvm/trunk/tools/llvm-nm/llvm-nm.cpp Sat Apr 27 08:32:53 2019<br>
@@ -934,6 +934,10 @@ static char getSymbolNMTypeChar(ELFObjec<br>
     return '?';<br>
   }<br>
<br>
+  uint8_t Binding = SymI->getOther() >> 4;<br>
+  if (Binding == ELF::STB_GNU_UNIQUE)<br>
+    return 'u';<br>
+<br>
   elf_section_iterator SecI = *SecIOrErr;<br>
   if (SecI != Obj.section_end()) {<br>
     uint32_t Type = SecI->getType();<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@lists.llvm.org" target="_blank">llvm-commits@lists.llvm.org</a><br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits" rel="noreferrer" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</blockquote></div>
</blockquote></div>