[PATCH] D61089: [Reassociation] Place moved instructions after landing pads

[David Greene via Phabricator via llvm-commits]

greened marked an inline comment as done.
greened added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/Reassociate.cpp:883
+    // BI, as if we hadn't found an existing neg.
+    if (const auto CatchSwitch = dyn_cast<CatchSwitchInst>(InsertPt))
+      break;
----------------
efriedma wrote:
> I don't think this does what you want; isEHPad() is true for catchswitch.  (It would be nice to have a testcase.)
> 
> I'm fine with bailing out of the loop in this rare case.
You are right.  Unfortunately, I am not confident I could construct a valid artificial testcase using `catchswitch`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61089/new/

https://reviews.llvm.org/D61089