[PATCH] D61089: [Reassociation] Place moved instructions after landing pads

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 30 14:33:34 PDT 2019


efriedma added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/Reassociate.cpp:883
+    // BI, as if we hadn't found an existing neg.
+    if (const auto CatchSwitch = dyn_cast<CatchSwitchInst>(InsertPt))
+      break;
----------------
I don't think this does what you want; isEHPad() is true for catchswitch.  (It would be nice to have a testcase.)

I'm fine with bailing out of the loop in this rare case.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61089/new/

https://reviews.llvm.org/D61089





More information about the llvm-commits mailing list