[PATCH] D60955: [llvm] Revert "Recommit r231221: "Devirtualize ~parser<T> by making it protected in base classes and making derived classes final""

Don Hinton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 1 09:22:09 PDT 2019


hintonda added a comment.

In D60955#1486217 <https://reviews.llvm.org/D60955#1486217>, @dblaikie wrote:

> Sorry, the title's multiple negatives confuse me a bit.


No worries.  I used `git llvm revert` to generate it, and just retitled with its suggestion.

> Maybe just "Revert r231221: ..." and then in the description explain why it's being reverted, and the history of it being previously reverted/reapplied (including why the revert was rolled back, and why this attempt to revert is different/addresses that problem).

Perfect, I'll do that.  Thanks...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60955/new/

https://reviews.llvm.org/D60955





More information about the llvm-commits mailing list