[PATCH] D60955: [llvm] Revert "Recommit r231221: "Devirtualize ~parser<T> by making it protected in base classes and making derived classes final""

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 1 08:55:15 PDT 2019


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Sorry, the title's multiple negatives confuse me a bit.

Maybe just "Revert r231221: ..." and then in the description explain why it's being reverted, and the history of it being previously reverted/reapplied (including why the revert was rolled back, and why this attempt to revert is different/addresses that problem).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60955/new/

https://reviews.llvm.org/D60955





More information about the llvm-commits mailing list