[PATCH] D61127: [llvm-objdump] Print newlines before and after "Disassembly of section ...:"

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked 2 inline comments as done.
MaskRay added inline comments.


================
Comment at: lld/test/ELF/arm-tls-gd32.s:94
 
-// CHECK: Disassembly
-// CHECK-NEXT: func:
+// CHECK-LABEL: 0000000000001000 func:
 // CHECK-NEXT:    1000:      00 f0 20 e3     nop
----------------
jhenderson wrote:
> This doesn't seem like a direct match to what was there before. What's the motivation here?
GNU objdump

```
Disassembly of section .fini:

0000000000005a6c <.fini>:
    5a6c:       48 83 ec 08             sub    rsp,0x8
```

llvm-objdump

```
Disassembly of section .fini:
0000000000005a6c .fini:
    5a6c: 48 83 ec 08                   subq    $8, %rsp
```

Note that in llvm-objdump, there are two lines matching `.fini:`. I have to prepend the address to make the check line match the second line. Since I'm changing it, using `CHECK-LABEL:` improves error messages in case the address changes.


================
Comment at: llvm/test/MC/X86/disassemble-zeroes.s:26
 
-// DISASM: Disassembly of section .text:
-// DISASM-NEXT: 0000000000000000 main:
----------------
jhenderson wrote:
> Not that I'm particularly bothered either way, but is there a reason you've removed this?
I think the `.text` section was not intended to check in this test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61127/new/

https://reviews.llvm.org/D61127