[PATCH] D61127: [llvm-objdump] Print newlines before and after "Disassembly of section ...:"

Wed May 1 02:26:11 PDT 2019

jhenderson added a comment.

Does GNU objdump print the blank line even before the first section?

It would be good to have, in one of the llvm-objdump-specific tests, a test for both this point, and more generally the blank lines before and after the section name. As far as I can tell, there is no direct testing for the before-newline in the llvm-objdump tests you've modified, except for where a very specific different feature of llvm-objdump is being tested.

================
Comment at: lld/test/ELF/arm-tls-gd32.s:94

-// CHECK: Disassembly
-// CHECK-NEXT: func:
+// CHECK-LABEL: 0000000000001000 func:
 // CHECK-NEXT:    1000:      00 f0 20 e3     nop
----------------
This doesn't seem like a direct match to what was there before. What's the motivation here?

================
Comment at: llvm/test/MC/X86/disassemble-zeroes.s:26

-// DISASM: Disassembly of section .text:
-// DISASM-NEXT: 0000000000000000 main:
----------------
Not that I'm particularly bothered either way, but is there a reason you've removed this?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61127/new/

https://reviews.llvm.org/D61127