[PATCH] D60600: [InstCombine] Fix a vector-of-pointers instcombine undef bug.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 30 16:19:25 PDT 2019


reames added a comment.

As noted in the bug, I think the "right" fix here is to change the LangRef.

Requiring integer constant indices just based on the type being indexed seems to be a bad idea, and without some strong justification, I'd argue should simply be removed.  If you want such geps to be better optimized, making hem behave like all other geps is better than special casing any particular transform.  (Like this one.)  To be clear, I'm suggesting allowing arbitrary constants as operands to said geps, not arbitrary values.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60600/new/

https://reviews.llvm.org/D60600





More information about the llvm-commits mailing list