[PATCH] D60600: [InstCombine] Fix a vector-of-pointers instcombine undef bug.

Tue Apr 30 16:14:39 PDT 2019

reames added a comment.

In D60600#1475212 <https://reviews.llvm.org/D60600#1475212>, @sheredom wrote:

> In D60600#1470778 <https://reviews.llvm.org/D60600#1470778>, @reames wrote:
>
> > I think you might be overcomplicating this.  I'd suggest the following:
> >
> > 1. scan all index types for a gep
> > 2. run current code, but if any operand was gep, skip the recursive call on the operand
> >
> >   It's slightly less powerful, but correct, and easy.  And frankly, optimize geps of struct types is probably rare enough we don't care.
> >
> >   p.s. Agreed on the location of test file, please add to existing tests.
>
>
> I don't really understand what your suggestion is here sorry - let me try and rephrase the suggestion and see if we agree?

I submitted a version along what I proposed as https://reviews.llvm.org/rL359633.  Please confirm that fixes your crash.  If you want to work on a better version of the fix, I'm happy to review, but I wanted to make sure the crash was resolved.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60600/new/

https://reviews.llvm.org/D60600