[PATCH] D61286: Skip functions with inallocas in argpromotion

[Bob Haarman via Phabricator via llvm-commits]

inglorion updated this revision to Diff 197383.
inglorion retitled this revision from "[argpromotion] reserve first argument of x86_thiscallcc functions" to "Skip functions with inallocas in argpromotion".
inglorion edited the summary of this revision.
inglorion removed a subscriber: efriedma.
inglorion added a comment.

Updated in response to @efriedma's comments. We now don't run
argpromotion on functions with inallocas. I've deleted some code
(mostly comments) that refers to them, and modified the test
which previously checked that we do perform the optimization in some
cases to instead check that we don't perform the optimization in
the case I found to be unsafe.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61286/new/

https://reviews.llvm.org/D61286

Files:
  llvm/lib/Transforms/IPO/ArgumentPromotion.cpp
  llvm/test/Transforms/ArgumentPromotion/inalloca.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61286.197383.patch
Type: text/x-patch
Size: 6631 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190430/49315cd2/attachment.bin>