[PATCH] D61286: [argpromotion] reserve first argument of x86_thiscallcc functions

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

Special-casing x86_thiscall seems too narrow; there are other x86 calling conventions that place arguments in registers, so I'm not confident this covers all the cases we care about.  Scanning for an inalloca argument should comprehensively cover all the relevant cases.

Alternatively, we could change the x86 calling convention code to make the result valid (if an argument is marked inalloca, force it into memory even if it's in an unexpected position in the argument list).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61286/new/

https://reviews.llvm.org/D61286