[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++

[Joel E. Denny via Phabricator via llvm-commits]

jdenny added a comment.

In D59168#1480801 <https://reviews.llvm.org/D59168#1480801>, @phosek wrote:

> In D59168#1480428 <https://reviews.llvm.org/D59168#1480428>, @jdenny wrote:
>
> > It seems we have roughly the same situation for their ABIs.  That is, for .so files, someone noted that libc++ and libunwind have always used the same version, .1, and openmp doesn't use a version (except in Debian packages).  In other words, for each of these three, a change in ABI compatibility has never been indicated.  For openmp only, it's apparently assumed a change never will need to be indicated (except in Debian packages).
>
>
> They already use `.2` for ABI v2 which is currently considered unstable but some project like Fuchsia already use. There's also an ongoing discussion to stabilize v2 <http://lists.llvm.org/pipermail/libcxx-dev/2019-March/000282.html>.


Thanks, I wasn't aware.  I still see only .1 in my build, so apparently a different config is needed.



================
Comment at: libunwind/CMakeLists.txt:190
 if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE)
-  set(DEFAULT_INSTALL_PREFIX lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION}/${LLVM_DEFAULT_TARGET_TRIPLE}/)
-  set(LIBUNWIND_LIBRARY_DIR ${LLVM_LIBRARY_OUTPUT_INTDIR}/clang/${CLANG_VERSION}/${LLVM_DEFAULT_TARGET_TRIPLE}/lib${LIBUNWIND_LIBDIR_SUFFIX})
+  set(LIBUNWIND_LIBRARY_DIR ${LLVM_LIBRARY_OUTPUT_INTDIR}/${LLVM_DEFAULT_TARGET_TRIPLE}/c++)
+  set(LIBUNWIND_INSTALL_LIBRARY_DIR lib${LLVM_LIBDIR_SUFFIX}/${LLVM_DEFAULT_TARGET_TRIPLE}/c++)
----------------
I naively assumed libunwind would have its own directory so it could be selected independently.  Does this mean any library for C++ goes in c++?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59168/new/

https://reviews.llvm.org/D59168