[PATCH] D61262: [AArch64] Implement MC support for Scalable Vector Extension 2 (SVE2)

[Cullen Rhodes via Phabricator via llvm-commits]

c-rhodes added a comment.

In D61262#1483818 <https://reviews.llvm.org/D61262#1483818>, @SjoerdMeijer wrote:

> But glancing over the patches would still be useful I think, i.e. the perhaps non-trivial tablegen parts.  I think the patches that at least need to be split up are the parts that deal with the TargetParser, AsmParser, etc.


The changes to the TargetParser, AsmParser and schedulers are adding new feature support, I think that constitutes one patch and I can split that out.

> With SVE, we still had quite some comments, even though they were mostly minor, but still.  But at the moment I can't even look at the code, the patch is too big. And then yes, you can probably start committing all the tablegen discriptions in one go, like you did with SVE.

If I split the above into a separate patch the remaining changes will be TableGen descriptions adding new instructions, along with tests. I understand this will still be a huge patch to review so I could break it down by encoding group (~26) as you suggest if that will make things easier.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61262/new/

https://reviews.llvm.org/D61262