[PATCH] D61262: [AArch64] Implement MC support for Scalable Vector Extension 2 (SVE2)
Cullen Rhodes via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 30 04:03:23 PDT 2019
c-rhodes added a comment.
================
Comment at: lib/Target/AArch64/AArch64SchedExynosM1.td:27
- list<Predicate> UnsupportedFeatures = [HasSVE];
+ list<Predicate> UnsupportedFeatures = [HasSVE, HasSVE2, HasSVE2AES,
+ HasSVE2SM4, HasSVE2SHA3,
----------------
javed.absar wrote:
> Instead of repeating this list everywhere you can at top level :
>
> class AArch64UnsupportedF { list<Predicate> F; }
> def SVEUnsupported F : AArch64UnsupportedF {
> let F = [HasSVE, HasSVE2, ... ];
> }
>
> and then in each AArch64SchedX.td ::
> list<Predicate> UnsupportedFeatures = SVEUnsupported.F;
>
> TableGen curently does not have globals otherwise it would be simpler, but this idiom works
>
That's neat!
I presume top-level is `AArch64.td`, I'm happy to make the change there
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61262/new/
https://reviews.llvm.org/D61262
More information about the llvm-commits
mailing list